From 547fb65e39b24d8b5bdb358d058e1b66206271d0 Mon Sep 17 00:00:00 2001
From: rcourtman <courtmanr@gmail.com>
Date: Sun, 21 Dec 2025 19:12:20 +0000
Subject: [PATCH] fix: remove unused runbook UI code to fix TypeScript errors

- Remove unused correlations state and constants from AIOverviewTable
- Remove unused runbook-related imports, state, and functions from Alerts
- Add type annotation to Set() to fix type error
- Removes dead code left over from runbook UI removal
---
 .../src/components/shared/AIOverviewTable.tsx | 15 +---
 frontend-modern/src/pages/Alerts.tsx          | 78 +------------------
 2 files changed, 5 insertions(+), 88 deletions(-)

diff --git a/frontend-modern/src/components/shared/AIOverviewTable.tsx b/frontend-modern/src/components/shared/AIOverviewTable.tsx
index 0049800..b2183ab 100644
--- a/frontend-modern/src/components/shared/AIOverviewTable.tsx
+++ b/frontend-modern/src/components/shared/AIOverviewTable.tsx
@@ -1,6 +1,6 @@
 import { Component, createEffect, createSignal, For, Show } from 'solid-js';
 import { AIAPI } from '@/api/ai';
-import type { FailurePrediction, InfrastructureChange, RemediationRecord, RemediationStats, ResourceCorrelation, AnomalyReport } from '@/types/aiIntelligence';
+import type { FailurePrediction, InfrastructureChange, RemediationRecord, RemediationStats, AnomalyReport } from '@/types/aiIntelligence';
 
 const DEFAULT_UPGRADE_URL = 'https://pulsemonitor.app/pro';
 
@@ -23,7 +23,6 @@ interface InsightRow {
  */
 export const AIOverviewTable: Component<{ showWhenEmpty?: boolean }> = (props) => {
     const [predictions, setPredictions] = createSignal<FailurePrediction[]>([]);
-    const [correlations, setCorrelations] = createSignal<ResourceCorrelation[]>([]);
     const [remediations, setRemediations] = createSignal<RemediationRecord[]>([]);
     const [remediationStats, setRemediationStats] = createSignal<RemediationStats | null>(null);
     const [changes, setChanges] = createSignal<InfrastructureChange[]>([]);
@@ -42,12 +41,10 @@ export const AIOverviewTable: Component<{ showWhenEmpty?: boolean }> = (props) =
     const [memoryLockedCount, setMemoryLockedCount] = createSignal(0);
 
     // Section expand/collapse state - default limits prevent overwhelming list
-    const [showAllDependencies, setShowAllDependencies] = createSignal(false);
     const [showAllActions, setShowAllActions] = createSignal(false);
     const [showAllChanges, setShowAllChanges] = createSignal(false);
 
     // Limits for each section (when not expanded)
-    const DEPENDENCY_LIMIT = 5;
     const ACTION_LIMIT = 5;
     const CHANGE_LIMIT = 5;
 
@@ -87,11 +84,9 @@ export const AIOverviewTable: Component<{ showWhenEmpty?: boolean }> = (props) =
                 const corrCount = corrResp.count || 0;
                 setInsightsLockedCount(predCount + corrCount);
                 setPredictions([]);
-                setCorrelations([]);
             } else {
                 setInsightsLockedCount(0);
                 setPredictions(predResp.predictions || []);
-                setCorrelations(corrResp.correlations || []);
             }
 
             // Handle impact lock
@@ -752,14 +747,6 @@ export const AIOverviewTable: Component<{ showWhenEmpty?: boolean }> = (props) =
                 <Show when={!loading() && anyHidden()}>
                     <div class="px-4 py-2 border-t border-gray-100 dark:border-gray-700/50 bg-gray-50/50 dark:bg-gray-800/30">
                         <div class="flex flex-wrap items-center gap-3 text-xs">
-                            <Show when={hiddenDependencies() > 0}>
-                                <button
-                                    class="text-indigo-600 dark:text-indigo-400 hover:underline"
-                                    onClick={() => setShowAllDependencies(true)}
-                                >
-                                    + {hiddenDependencies()} more dependencies
-                                </button>
-                            </Show>
                             <Show when={hiddenActions() > 0}>
                                 <button
                                     class="text-emerald-600 dark:text-emerald-400 hover:underline"
diff --git a/frontend-modern/src/pages/Alerts.tsx b/frontend-modern/src/pages/Alerts.tsx
index 882191a..cc4b7fa 100644
--- a/frontend-modern/src/pages/Alerts.tsx
+++ b/frontend-modern/src/pages/Alerts.tsx
@@ -32,7 +32,7 @@ import History from 'lucide-solid/icons/history';
 import Gauge from 'lucide-solid/icons/gauge';
 import Send from 'lucide-solid/icons/send';
 import Calendar from 'lucide-solid/icons/calendar';
-import { getPatrolStatus, getFindings, getFindingsHistory, getPatrolRunHistory, forcePatrol, subscribeToPatrolStream, dismissFinding, suppressFinding, getSuppressionRules, addSuppressionRule, deleteSuppressionRule, getRunbooksForFinding, executeRunbook, type Finding, type PatrolStatus, type PatrolRunRecord, type SuppressionRule, type RunbookInfo, type RunbookExecutionResult, severityColors, formatTimestamp, categoryLabels } from '@/api/patrol';
+import { getPatrolStatus, getFindings, getFindingsHistory, getPatrolRunHistory, forcePatrol, subscribeToPatrolStream, dismissFinding, suppressFinding, getSuppressionRules, addSuppressionRule, deleteSuppressionRule, type Finding, type PatrolStatus, type PatrolRunRecord, type SuppressionRule, severityColors, formatTimestamp, categoryLabels } from '@/api/patrol';
 import { aiChatStore } from '@/stores/aiChat';
 
 type AlertTab = 'overview' | 'thresholds' | 'destinations' | 'schedule' | 'history';
@@ -2178,34 +2178,19 @@ function OverviewTab(props: {
   const [newRuleDescription, setNewRuleDescription] = createSignal('');
   const [licenseFeatures, setLicenseFeatures] = createSignal<LicenseFeatureStatus | null>(null);
   const [licenseLoading, setLicenseLoading] = createSignal(false);
-  const [runbooksByFinding, setRunbooksByFinding] = createSignal<Record<string, RunbookInfo[]>>({});
-  const [runbookLoadingByFinding, setRunbookLoadingByFinding] = createSignal<Record<string, boolean>>({});
-  const [runbookSelection, setRunbookSelection] = createSignal<Record<string, string>>({});
-  const [runbookResults, setRunbookResults] = createSignal<Record<string, RunbookExecutionResult | null>>({});
-  const [runbookErrors, setRunbookErrors] = createSignal<Record<string, string>>({});
-  const [expandedRunbookFinding, setExpandedRunbookFinding] = createSignal<string | null>(null);
   const [remediationsByFinding, setRemediationsByFinding] = createSignal<Record<string, RemediationRecord[]>>({});
   const [remediationLoadingByFinding, setRemediationLoadingByFinding] = createSignal<Record<string, boolean>>({});
-  const [remediationErrorsByFinding, setRemediationErrorsByFinding] = createSignal<Record<string, string>>({});
-  const [remediationLockedByFinding, setRemediationLockedByFinding] = createSignal<Record<string, boolean>>({});
-  const [remediationUpgradeURLByFinding, setRemediationUpgradeURLByFinding] = createSignal<Record<string, string>>({});
   const hasAIAlertsFeature = createMemo(() => {
     const status = licenseFeatures();
     if (!status) return true;
     return Boolean(status.features?.['ai_alerts']);
   });
-  const hasAutoFixFeature = createMemo(() => {
-    const status = licenseFeatures();
-    if (!status) return false;
-    return Boolean(status.features?.['ai_autofix']);
-  });
   const showAIAlertsUpgrade = createMemo(() => {
     const status = licenseFeatures();
     if (!status) return false;
     return !status.features?.['ai_alerts'];
   });
   const aiAlertsUpgradeURL = createMemo(() => licenseFeatures()?.upgrade_url || 'https://pulsemonitor.app/pro');
-  const autoFixUpgradeURL = createMemo(() => licenseFeatures()?.upgrade_url || 'https://pulsemonitor.app/pro');
   // Live streaming state for running patrol
   const [expandedLiveStream, setExpandedLiveStream] = createSignal(false);
   // Track streaming blocks for sequential display (like AI chat)
@@ -2421,73 +2406,18 @@ function OverviewTab(props: {
     }
   };
 
-  const loadRunbooks = async (findingId: string) => {
-    setRunbookLoadingByFinding((prev) => ({ ...prev, [findingId]: true }));
-    setRunbookErrors((prev) => ({ ...prev, [findingId]: '' }));
-    try {
-      const runbooks = await getRunbooksForFinding(findingId);
-      setRunbooksByFinding((prev) => ({ ...prev, [findingId]: runbooks }));
-      if (runbooks.length > 0 && !runbookSelection()[findingId]) {
-        setRunbookSelection((prev) => ({ ...prev, [findingId]: runbooks[0].id }));
-      }
-    } catch (err) {
-      const message = err instanceof Error ? err.message : 'Failed to load runbooks';
-      setRunbookErrors((prev) => ({ ...prev, [findingId]: message }));
-    } finally {
-      setRunbookLoadingByFinding((prev) => ({ ...prev, [findingId]: false }));
-    }
-  };
-
-  const toggleRunbookPanel = (findingId: string) => {
-    setExpandedRunbookFinding((prev) => (prev === findingId ? null : findingId));
-    if (!runbooksByFinding()[findingId] && !runbookLoadingByFinding()[findingId]) {
-      void loadRunbooks(findingId);
-    }
-  };
-
   const loadRemediationsForFinding = async (findingId: string) => {
     setRemediationLoadingByFinding((prev) => ({ ...prev, [findingId]: true }));
-    setRemediationErrorsByFinding((prev) => ({ ...prev, [findingId]: '' }));
     try {
       const response = await AIAPI.getRemediations({ findingId, limit: 3 });
-      const locked = Boolean(response.license_required);
-      setRemediationLockedByFinding((prev) => ({ ...prev, [findingId]: locked }));
-      if (response.upgrade_url) {
-        setRemediationUpgradeURLByFinding((prev) => ({ ...prev, [findingId]: response.upgrade_url || '' }));
-      }
-      setRemediationsByFinding((prev) => ({ ...prev, [findingId]: locked ? [] : (response.remediations || []) }));
+      setRemediationsByFinding((prev) => ({ ...prev, [findingId]: response.remediations || [] }));
     } catch (err) {
-      const message = err instanceof Error ? err.message : 'Failed to load remediation history';
-      setRemediationErrorsByFinding((prev) => ({ ...prev, [findingId]: message }));
+      console.error('Failed to load remediation history', err);
     } finally {
       setRemediationLoadingByFinding((prev) => ({ ...prev, [findingId]: false }));
     }
   };
 
-  const runSelectedRunbook = async (findingId: string) => {
-    const runbookId = runbookSelection()[findingId];
-    if (!runbookId) {
-      setRunbookErrors((prev) => ({ ...prev, [findingId]: 'Select a runbook to execute.' }));
-      return;
-    }
-    setRunbookErrors((prev) => ({ ...prev, [findingId]: '' }));
-    setRunbookResults((prev) => ({ ...prev, [findingId]: null }));
-    setRunbookLoadingByFinding((prev) => ({ ...prev, [findingId]: true }));
-    try {
-      const result = await executeRunbook(findingId, runbookId);
-      setRunbookResults((prev) => ({ ...prev, [findingId]: result }));
-      if (result.resolved) {
-        fetchAiData();
-      }
-    } catch (err) {
-      const message = err instanceof Error ? err.message : 'Runbook execution failed';
-      setRunbookErrors((prev) => ({ ...prev, [findingId]: message }));
-    } finally {
-      setRunbookLoadingByFinding((prev) => ({ ...prev, [findingId]: false }));
-      void loadRemediationsForFinding(findingId);
-    }
-  };
-
   // Handle force patrol button click
   const handleForcePatrol = async (deep: boolean = false) => {
     setForcePatrolLoading(true);
@@ -5826,7 +5756,7 @@ function HistoryTab() {
       return;
     }
     setResourceIncidentPanel({ resourceId, resourceName });
-    setExpandedResourceIncidentIds(new Set());
+    setExpandedResourceIncidentIds(new Set<string>());
     if (!(resourceId in resourceIncidents())) {
       await loadResourceIncidents(resourceId);
     }