From 50843d3013f5dc1431e22290e038eeb3e1d553f9 Mon Sep 17 00:00:00 2001
From: rcourtman <courtmanr@gmail.com>
Date: Mon, 1 Dec 2025 15:00:56 +0000
Subject: [PATCH] test: Add LoadAPITokens error path tests

- Test nonexistent file returns empty slice (not error)
- Test empty file returns empty slice
- Test invalid JSON returns error
- Improves LoadAPITokens coverage from 80% to 93.3%
---
 internal/config/api_tokens_test.go | 54 ++++++++++++++++++++++++++++++
 1 file changed, 54 insertions(+)

diff --git a/internal/config/api_tokens_test.go b/internal/config/api_tokens_test.go
index d267515..682aaba 100644
--- a/internal/config/api_tokens_test.go
+++ b/internal/config/api_tokens_test.go
@@ -211,3 +211,57 @@ func TestLoadAPITokensAppliesLegacyScopes(t *testing.T) {
 		t.Fatalf("expected legacy token to default to wildcard scope, got %#v", tokens[0].Scopes)
 	}
 }
+
+func TestLoadAPITokens_ErrorPaths(t *testing.T) {
+	t.Run("nonexistent file returns empty slice", func(t *testing.T) {
+		dir := t.TempDir()
+		persistence := NewConfigPersistence(dir)
+
+		tokens, err := persistence.LoadAPITokens()
+		if err != nil {
+			t.Fatalf("expected no error for missing file, got: %v", err)
+		}
+		if len(tokens) != 0 {
+			t.Fatalf("expected empty slice, got %d tokens", len(tokens))
+		}
+	})
+
+	t.Run("empty file returns empty slice", func(t *testing.T) {
+		dir := t.TempDir()
+		persistence := NewConfigPersistence(dir)
+		if err := persistence.EnsureConfigDir(); err != nil {
+			t.Fatalf("EnsureConfigDir: %v", err)
+		}
+
+		// Write empty file
+		if err := os.WriteFile(filepath.Join(dir, "api_tokens.json"), []byte{}, 0600); err != nil {
+			t.Fatalf("write file: %v", err)
+		}
+
+		tokens, err := persistence.LoadAPITokens()
+		if err != nil {
+			t.Fatalf("expected no error for empty file, got: %v", err)
+		}
+		if len(tokens) != 0 {
+			t.Fatalf("expected empty slice, got %d tokens", len(tokens))
+		}
+	})
+
+	t.Run("invalid JSON returns error", func(t *testing.T) {
+		dir := t.TempDir()
+		persistence := NewConfigPersistence(dir)
+		if err := persistence.EnsureConfigDir(); err != nil {
+			t.Fatalf("EnsureConfigDir: %v", err)
+		}
+
+		// Write invalid JSON
+		if err := os.WriteFile(filepath.Join(dir, "api_tokens.json"), []byte("not valid json"), 0600); err != nil {
+			t.Fatalf("write file: %v", err)
+		}
+
+		_, err := persistence.LoadAPITokens()
+		if err == nil {
+			t.Fatal("expected error for invalid JSON, got nil")
+		}
+	})
+}