From 497bdb625e3a82c8a0774243af313ee429914c74 Mon Sep 17 00:00:00 2001 From: rcourtman Date: Thu, 6 Nov 2025 12:47:02 +0000 Subject: [PATCH] Fix version embedding in Docker builds The Docker build was only setting internal/dockeragent.Version but not main.Version, causing the pulse binary to show "dev" instead of the actual version. Now matches build-release.sh ldflags pattern. Related to v4.26.1 release --- Dockerfile | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Dockerfile b/Dockerfile index 7809e76..eb9e709 100644 --- a/Dockerfile +++ b/Dockerfile @@ -47,8 +47,10 @@ COPY --from=frontend-builder /app/frontend-modern/dist ./internal/api/frontend-m RUN --mount=type=cache,id=pulse-go-mod,target=/go/pkg/mod \ --mount=type=cache,id=pulse-go-build,target=/root/.cache/go-build \ VERSION="v$(cat VERSION | tr -d '\n')" && \ + BUILD_TIME=$(date -u +"%Y-%m-%dT%H:%M:%SZ") && \ + GIT_COMMIT=$(git rev-parse --short HEAD 2>/dev/null || echo "unknown") && \ CGO_ENABLED=0 GOOS=linux go build \ - -ldflags="-s -w -X github.com/rcourtman/pulse-go-rewrite/internal/dockeragent.Version=${VERSION}" \ + -ldflags="-s -w -X main.Version=${VERSION} -X main.BuildTime=${BUILD_TIME} -X main.GitCommit=${GIT_COMMIT} -X github.com/rcourtman/pulse-go-rewrite/internal/dockeragent.Version=${VERSION}" \ -trimpath \ -o pulse ./cmd/pulse