danvics/Pulse
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Show CPU core count on EnhancedCPUBar progress bar

Browse source
This commit is contained in:
rcourtman 2025-11-29 21:47:22 +00:00
parent 0dd65c5db2
commit 46f90e1585
3 changed files with 14 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
frontend-modern/src/components/Dashboard/EnhancedCPUBar.tsx
View file

@ -82,6 +82,9 @@ export function EnhancedCPUBar(props: EnhancedCPUBarProps) {
{/* Label */} {/* Label */}
<span class="absolute inset-0 flex items-center justify-center text-[10px] font-semibold text-gray-700 dark:text-gray-100 leading-none pointer-events-none"> <span class="absolute inset-0 flex items-center justify-center text-[10px] font-semibold text-gray-700 dark:text-gray-100 leading-none pointer-events-none">
{formatPercent(props.usage)} {formatPercent(props.usage)}
<Show when={props.cores}>
<span class="ml-1 text-[9px] font-normal opacity-70">({props.cores}c)</span>
</Show>
</span> </span>
</div> </div>

4
internal/api/system_settings.go
View file

@ -294,8 +294,8 @@ func validateSystemSettings(_ *config.SystemSettings, rawRequest map[string]inte
if !ok { if !ok {
return fmt.Errorf("discoveryConfig.max_concurrent must be a number") return fmt.Errorf("discoveryConfig.max_concurrent must be a number")
} }
if value <= 0 || value > 1000 { if value <= 0 || value > 1000 || value != float64(int(value)) {
return fmt.Errorf("discoveryConfig.max_concurrent must be between 1 and 1000") return fmt.Errorf("discoveryConfig.max_concurrent must be a whole number between 1 and 1000")
} }
} }

14
internal/api/system_settings_validate_test.go
View file

@ -1068,18 +1068,22 @@ func TestValidateSystemSettings_BoundaryConditions(t *testing.T) {
{name: "connectionTimeout: 299.999", input: map[string]interface{}{"connectionTimeout": 299.999}, expectError: false}, {name: "connectionTimeout: 299.999", input: map[string]interface{}{"connectionTimeout": 299.999}, expectError: false},
{name: "connectionTimeout: 300.001", input: map[string]interface{}{"connectionTimeout": 300.001}, expectError: true}, {name: "connectionTimeout: 300.001", input: map[string]interface{}{"connectionTimeout": 300.001}, expectError: true},
// Max concurrent boundaries // Max concurrent boundaries - fractional values are rejected since it's a goroutine count
// Note: The validation is `value <= 0 || value > 1000`, so 0.999 is actually valid
{ {
name: "max_concurrent: 0.999", name: "max_concurrent: 0.999 fractional rejected",
input: map[string]interface{}{"discoveryConfig": map[string]interface{}{"max_concurrent": 0.999}}, input: map[string]interface{}{"discoveryConfig": map[string]interface{}{"max_concurrent": 0.999}},
expectError: false, expectError: true,
}, },
{ {
name: "max_concurrent: 1000.001", name: "max_concurrent: 1000.001 fractional rejected",
input: map[string]interface{}{"discoveryConfig": map[string]interface{}{"max_concurrent": 1000.001}}, input: map[string]interface{}{"discoveryConfig": map[string]interface{}{"max_concurrent": 1000.001}},
expectError: true, expectError: true,
}, },
{
name: "max_concurrent: 5.5 fractional rejected",
input: map[string]interface{}{"discoveryConfig": map[string]interface{}{"max_concurrent": 5.5}},
expectError: true,
},
} }
for _, tt := range tests { for _, tt := range tests {