From 3e2715d3f5c1e80b9ce98901add23b1f519a8e54 Mon Sep 17 00:00:00 2001 From: rcourtman Date: Fri, 28 Nov 2025 11:36:24 +0000 Subject: [PATCH] Fix macOS unified agent binary naming in Makefile Makefile was building macOS unified agent binaries with 'macos-' prefix (e.g., pulse-agent-macos-amd64) but the download endpoint and agent's determineArch() function use 'darwin-' prefix (e.g., pulse-agent-darwin-amd64). This mismatch could cause macOS agent self-updates to fail because the server would look for the darwin-prefixed binary that doesn't exist. Note: The release build script (scripts/build-release.sh) already uses the correct 'darwin-' prefix, so this only affects local development builds. Related to #768 --- Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 446fa26..bdcf303 100644 --- a/Makefile +++ b/Makefile @@ -92,8 +92,8 @@ build-agents: echo "Building unified agent binaries..." && \ CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -ldflags="-s -w -X main.Version=v$$VERSION" -trimpath -o bin/pulse-agent-linux-amd64 ./cmd/pulse-agent && \ CGO_ENABLED=0 GOOS=linux GOARCH=arm64 go build -ldflags="-s -w -X main.Version=v$$VERSION" -trimpath -o bin/pulse-agent-linux-arm64 ./cmd/pulse-agent && \ - CGO_ENABLED=0 GOOS=darwin GOARCH=amd64 go build -ldflags="-s -w -X main.Version=v$$VERSION" -trimpath -o bin/pulse-agent-macos-amd64 ./cmd/pulse-agent && \ - CGO_ENABLED=0 GOOS=darwin GOARCH=arm64 go build -ldflags="-s -w -X main.Version=v$$VERSION" -trimpath -o bin/pulse-agent-macos-arm64 ./cmd/pulse-agent && \ + CGO_ENABLED=0 GOOS=darwin GOARCH=amd64 go build -ldflags="-s -w -X main.Version=v$$VERSION" -trimpath -o bin/pulse-agent-darwin-amd64 ./cmd/pulse-agent && \ + CGO_ENABLED=0 GOOS=darwin GOARCH=arm64 go build -ldflags="-s -w -X main.Version=v$$VERSION" -trimpath -o bin/pulse-agent-darwin-arm64 ./cmd/pulse-agent && \ CGO_ENABLED=0 GOOS=windows GOARCH=amd64 go build -ldflags="-s -w -X main.Version=v$$VERSION" -trimpath -o bin/pulse-agent-windows-amd64.exe ./cmd/pulse-agent @ln -sf pulse-host-agent-windows-amd64.exe bin/pulse-host-agent-windows-amd64 @echo "✓ All agent binaries built in bin/"