From 3a381e764afe88091a0e638922b23cae89d41d39 Mon Sep 17 00:00:00 2001
From: rcourtman <courtmanr@gmail.com>
Date: Fri, 14 Nov 2025 22:13:35 +0000
Subject: [PATCH] Add cleanup trap and better error handling to
 update_allowed_nodes

- Add trap to remove temp file on function return (success or failure)
- Add error check for mv command with descriptive message
- Ensure config file has proper permissions after update

This prevents orphaned temp files when errors occur and provides
better diagnostics when file operations fail.
---
 scripts/install-sensor-proxy.sh | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/scripts/install-sensor-proxy.sh b/scripts/install-sensor-proxy.sh
index f77c643..ddb802d 100755
--- a/scripts/install-sensor-proxy.sh
+++ b/scripts/install-sensor-proxy.sh
@@ -72,6 +72,9 @@ update_allowed_nodes() {
     local tmp_config
     tmp_config=$(mktemp)
 
+    # Ensure temp file is cleaned up on exit (success or failure)
+    trap "rm -f '$tmp_config'" RETURN
+
     # Remove any existing allowed_nodes section (including the YAML key and all list items)
     # This handles multi-line allowed_nodes blocks and associated comment headers
     if [[ -f "$config_file" ]]; then
@@ -138,7 +141,14 @@ update_allowed_nodes() {
     } >> "$tmp_config"
 
     # Replace original file
-    mv "$tmp_config" "$config_file"
+    if ! mv "$tmp_config" "$config_file"; then
+        echo "ERROR: Failed to update $config_file - check permissions" >&2
+        return 1
+    fi
+
+    # Ensure proper permissions
+    chmod 0644 "$config_file" 2>/dev/null || true
+    chown pulse-sensor-proxy:pulse-sensor-proxy "$config_file" 2>/dev/null || true
 }
 
 BINARY_PATH="/usr/local/bin/pulse-sensor-proxy"