danvics/Pulse
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

perf: Cache hostname lowercase in temperature proxy lookups

Browse source 
Pre-compute strings.ToLower(hostname) before loops that search for
matching PVE instances. Avoids repeated lowercasing in two functions.
This commit is contained in:
rcourtman 2025-12-02 15:43:41 +00:00
parent 6931fa34cd
commit 25294da5d5
1 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
internal/api/temperature_proxy.go
View file

@ -231,6 +231,7 @@ func (h *TemperatureProxyHandlers) HandleRegister(w http.ResponseWriter, r *http
var matchedInstance *config.PVEInstance var matchedInstance *config.PVEInstance
var matchedIndex int var matchedIndex int
var matchedEndpointIndex = -1 // For cluster nodes, track which endpoint matched var matchedEndpointIndex = -1 // For cluster nodes, track which endpoint matched
hostnameLower := strings.ToLower(hostname)
for i := range nodesConfig.PVEInstances { for i := range nodesConfig.PVEInstances {
instance := &nodesConfig.PVEInstances[i] instance := &nodesConfig.PVEInstances[i]
@ -243,7 +244,7 @@ func (h *TemperatureProxyHandlers) HandleRegister(w http.ResponseWriter, r *http
} }
// Try to match by hostname in the Host field or cluster endpoints // Try to match by hostname in the Host field or cluster endpoints
if strings.Contains(strings.ToLower(instance.Host), strings.ToLower(hostname)) { if strings.Contains(strings.ToLower(instance.Host), hostnameLower) {
matchedInstance = instance matchedInstance = instance
matchedIndex = i matchedIndex = i
break break
@ -252,7 +253,7 @@ func (h *TemperatureProxyHandlers) HandleRegister(w http.ResponseWriter, r *http
// Check cluster endpoints // Check cluster endpoints
if instance.IsCluster { if instance.IsCluster {
for j, ep := range instance.ClusterEndpoints { for j, ep := range instance.ClusterEndpoints {
if strings.EqualFold(ep.NodeName, hostname) || strings.Contains(strings.ToLower(ep.Host), strings.ToLower(hostname)) { if strings.EqualFold(ep.NodeName, hostname) || strings.Contains(strings.ToLower(ep.Host), hostnameLower) {
matchedInstance = instance matchedInstance = instance
matchedIndex = i matchedIndex = i
matchedEndpointIndex = j matchedEndpointIndex = j
@ -480,11 +481,12 @@ func (h *TemperatureProxyHandlers) HandleUnregister(w http.ResponseWriter, r *ht
// Find matching PVE instance // Find matching PVE instance
var matchedIndex = -1 var matchedIndex = -1
var matchedName string var matchedName string
hostnameLower := strings.ToLower(hostname)
for i := range nodesConfig.PVEInstances { for i := range nodesConfig.PVEInstances {
instance := &nodesConfig.PVEInstances[i] instance := &nodesConfig.PVEInstances[i]
if strings.Contains(strings.ToLower(instance.Host), strings.ToLower(hostname)) { if strings.Contains(strings.ToLower(instance.Host), hostnameLower) {
matchedIndex = i matchedIndex = i
matchedName = instance.Name matchedName = instance.Name
break break
@ -492,7 +494,7 @@ func (h *TemperatureProxyHandlers) HandleUnregister(w http.ResponseWriter, r *ht
if instance.IsCluster { if instance.IsCluster {
for _, ep := range instance.ClusterEndpoints { for _, ep := range instance.ClusterEndpoints {
if strings.EqualFold(ep.NodeName, hostname) || strings.Contains(strings.ToLower(ep.Host), strings.ToLower(hostname)) { if strings.EqualFold(ep.NodeName, hostname) || strings.Contains(strings.ToLower(ep.Host), hostnameLower) {
matchedIndex = i matchedIndex = i
matchedName = instance.Name matchedName = instance.Name
break break