From 1a595b3b2e92800bed562e8829fdd7cedfb551a0 Mon Sep 17 00:00:00 2001
From: rcourtman <courtmanr@gmail.com>
Date: Tue, 2 Dec 2025 00:54:37 +0000
Subject: [PATCH] test: Add edge cases for UniversalRateLimitMiddleware

Cover nil config initialization and static asset bypass paths.
Coverage: UniversalRateLimitMiddleware 87.5% -> 100%
---
 internal/api/rate_limit_config_test.go | 67 ++++++++++++++++++++++++++
 1 file changed, 67 insertions(+)

diff --git a/internal/api/rate_limit_config_test.go b/internal/api/rate_limit_config_test.go
index d593f4a..15c9d9a 100644
--- a/internal/api/rate_limit_config_test.go
+++ b/internal/api/rate_limit_config_test.go
@@ -421,6 +421,73 @@ func TestUniversalRateLimitMiddleware_HeaderFormat(t *testing.T) {
 	}
 }
 
+func TestUniversalRateLimitMiddleware_InitializesIfNeeded(t *testing.T) {
+	// Save and restore global state
+	saved := globalRateLimitConfig
+	globalRateLimitConfig = nil
+	t.Cleanup(func() {
+		globalRateLimitConfig = saved
+	})
+
+	handler := http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+		w.WriteHeader(http.StatusOK)
+	})
+
+	// Create middleware with nil config - should initialize
+	middleware := UniversalRateLimitMiddleware(handler)
+
+	if globalRateLimitConfig == nil {
+		t.Fatal("globalRateLimitConfig should have been initialized by middleware creation")
+	}
+
+	// Verify middleware works correctly after initialization
+	req := httptest.NewRequest(http.MethodGet, "/api/health", nil)
+	rr := httptest.NewRecorder()
+	middleware.ServeHTTP(rr, req)
+
+	if rr.Code != http.StatusOK {
+		t.Fatalf("expected status 200, got %d", rr.Code)
+	}
+}
+
+func TestUniversalRateLimitMiddleware_StaticAssetBypass(t *testing.T) {
+	InitializeRateLimiters()
+
+	handlerCalled := false
+	handler := http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+		handlerCalled = true
+		w.WriteHeader(http.StatusOK)
+	})
+	middleware := UniversalRateLimitMiddleware(handler)
+
+	// Static asset paths (not /api or /ws prefixed) should bypass rate limiting
+	tests := []struct {
+		path string
+	}{
+		{"/index.html"},
+		{"/static/js/app.js"},
+		{"/favicon.ico"},
+		{"/assets/style.css"},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.path, func(t *testing.T) {
+			handlerCalled = false
+			req := httptest.NewRequest(http.MethodGet, tt.path, nil)
+			rr := httptest.NewRecorder()
+
+			middleware.ServeHTTP(rr, req)
+
+			if !handlerCalled {
+				t.Errorf("handler should have been called for static asset path %s", tt.path)
+			}
+			if rr.Code != http.StatusOK {
+				t.Errorf("expected status 200 for static asset, got %d", rr.Code)
+			}
+		})
+	}
+}
+
 func TestResetRateLimitForIP(t *testing.T) {
 	t.Run("nil globalRateLimitConfig does not panic", func(t *testing.T) {
 		// Save current config and restore after test