From 16603e8b4ada038a2974b7a113f91ea101f2eae9 Mon Sep 17 00:00:00 2001
From: rcourtman <courtmanr@gmail.com>
Date: Thu, 27 Nov 2025 09:48:29 +0000
Subject: [PATCH] fix: remove ineffectual assignments

- Fix loop variable reassignment in config_handlers.go
- Remove redundant boolean assignments in swarm.go
---
 internal/api/config_handlers.go | 4 ++--
 internal/dockeragent/swarm.go   | 6 ------
 2 files changed, 2 insertions(+), 8 deletions(-)

diff --git a/internal/api/config_handlers.go b/internal/api/config_handlers.go
index 91548a1..bfc9b4d 100644
--- a/internal/api/config_handlers.go
+++ b/internal/api/config_handlers.go
@@ -805,10 +805,10 @@ func (h *ConfigHandlers) GetAllNodesForAPI() []NodeResponse {
 	containerSSHBlocked := isContainerSSHRestricted()
 
 	// Add PVE nodes
-	for i, pve := range h.config.PVEInstances {
+	for i := range h.config.PVEInstances {
 		// Refresh cluster metadata if we previously failed to detect endpoints
 		h.maybeRefreshClusterInfo(&h.config.PVEInstances[i])
-		pve = h.config.PVEInstances[i]
+		pve := h.config.PVEInstances[i]
 		node := NodeResponse{
 			ID:                           generateNodeID("pve", i),
 			Type:                         "pve",
diff --git a/internal/dockeragent/swarm.go b/internal/dockeragent/swarm.go
index 8bcc95f..1553b58 100644
--- a/internal/dockeragent/swarm.go
+++ b/internal/dockeragent/swarm.go
@@ -82,12 +82,6 @@ func (a *Agent) collectSwarmData(ctx context.Context, info systemtypes.Info, con
 	includeTasks := a.cfg.IncludeTasks
 
 	if info.Swarm.LocalNodeState != swarmtypes.LocalNodeStateActive {
-		if !includeServices {
-			includeServices = false
-		}
-		if !includeTasks {
-			includeTasks = false
-		}
 		return nil, nil, swarmInfo
 	}