danvics/Pulse
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(security): show actual backend error instead of misleading DISABLE_AUTH message

Browse source 
The frontend was incorrectly assuming any 401/403 response from the
quick-setup endpoint meant the legacy DISABLE_AUTH flag was present.

This was wrong - the real causes are typically:
- Missing bootstrap token (for first-run setup)
- Invalid bootstrap token
- Authentication required for existing setups

Now the frontend properly displays the actual error message from the
backend, which includes helpful instructions for retrieving the
bootstrap token.
This commit is contained in:
rcourtman 2025-12-15 22:30:24 +00:00
parent a3909f1b39
commit 101fa62997
1 changed files with 5 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
frontend-modern/src/components/Settings/QuickSecuritySetup.tsx
View file

@ -95,11 +95,6 @@ export const QuickSecuritySetup: Component<QuickSecuritySetupProps> = (props) =>
});
if (!response.ok) {
if (response.status === 401 || response.status === 403) {
throw new Error(
'Pulse detected a legacy DISABLE_AUTH flag. Remove that environment flag and restart Pulse before enabling security here.',
);
}
const error = await response.text();
throw new Error(error || 'Failed to setup security');
}
@ -111,7 +106,7 @@ export const QuickSecuritySetup: Component<QuickSecuritySetupProps> = (props) =>
// Security was already configured, don't show credentials
showError(
result.message ||
'Security is already configured. Please remove existing security first if you want to reconfigure.',
'Security is already configured. Please remove existing security first if you want to reconfigure.',
);
if (props.onConfigured) {
props.onConfigured();
@ -232,22 +227,20 @@ Important:
<button
type="button"
onClick={() => setUseCustomPassword(false)}
class={`px-3 py-1 text-xs rounded-lg transition-colors ${
!useCustomPassword()
class={`px-3 py-1 text-xs rounded-lg transition-colors ${!useCustomPassword()
? 'bg-blue-600 text-white'
: 'bg-gray-200 dark:bg-gray-700 text-gray-700 dark:text-gray-300 hover:bg-gray-300 dark:hover:bg-gray-600'
}`}
}`}
>
Auto-Generate
</button>
<button
type="button"
onClick={() => setUseCustomPassword(true)}
class={`px-3 py-1 text-xs rounded-lg transition-colors ${
useCustomPassword()
class={`px-3 py-1 text-xs rounded-lg transition-colors ${useCustomPassword()
? 'bg-blue-600 text-white'
: 'bg-gray-200 dark:bg-gray-700 text-gray-700 dark:text-gray-300 hover:bg-gray-300 dark:hover:bg-gray-600'
}`}
}`}
>
Custom
</button>