From 07f198da63230d8015fe557b8ad59544410f1f92 Mon Sep 17 00:00:00 2001 From: rcourtman Date: Mon, 20 Oct 2025 20:58:25 +0000 Subject: [PATCH] fix: pass Pulse server URL as argument instead of env var for proxy installer Changes: - Replace PULSE_SENSOR_PROXY_FALLBACK_URL env export with --pulse-server argument - Remove --quiet flag from installer invocation to show download progress - More reliable than environment variable inheritance in subshells This ensures the proxy installer can reliably download the binary from the Pulse server fallback when GitHub is unavailable. --- internal/api/config_handlers.go | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/internal/api/config_handlers.go b/internal/api/config_handlers.go index 6108741..ebae077 100644 --- a/internal/api/config_handlers.go +++ b/internal/api/config_handlers.go @@ -3704,11 +3704,8 @@ if [ "$TEMP_MONITORING_AVAILABLE" = true ] && [ "$PULSE_IS_CONTAINERIZED" = true -o "$PROXY_INSTALLER" 2>/dev/null; then chmod +x "$PROXY_INSTALLER" - # Set fallback URL for installer to download binary from Pulse server - export PULSE_SENSOR_PROXY_FALLBACK_URL="%s/api/install/pulse-sensor-proxy" - - # Run installer - INSTALL_OUTPUT=$("$PROXY_INSTALLER" --ctid "$PULSE_CTID" --quiet 2>&1) + # Run installer with Pulse server as fallback + INSTALL_OUTPUT=$("$PROXY_INSTALLER" --ctid "$PULSE_CTID" --pulse-server "%s" 2>&1) INSTALL_STATUS=$? if [ -n "$INSTALL_OUTPUT" ]; then