danvics/Pulse
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(ai): send Ollama URL when using default localhost address

Browse source 
The form pre-fills the Ollama URL field with http://localhost:11434 but
compared it against that same default value to detect changes. This meant
users configuring Ollama with the default URL never actually saved it.

Also shows actual backend error messages instead of generic "Failed to update"
when toggling the AI enable switch.

Related to #847
This commit is contained in:
rcourtman 2025-12-15 10:03:15 +00:00
parent eac510bb5e
commit 06ae5295b3
1 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
frontend-modern/src/components/Settings/AISettings.tsx
View file

@ -297,8 +297,9 @@ export const AISettings: Component = () => {
if (form.deepseekApiKey.trim()) {
payload.deepseek_api_key = form.deepseekApiKey.trim();
}
// Always include Ollama URL changes
if (form.ollamaBaseUrl !== (settings()?.ollama_base_url || 'http://localhost:11434')) {
// Always include Ollama URL if it has a value and differs from what's saved
// Compare against actual saved value (empty string if not set), not a prefilled default
if (form.ollamaBaseUrl.trim() && form.ollamaBaseUrl.trim() !== (settings()?.ollama_base_url || '')) {
payload.ollama_base_url = form.ollamaBaseUrl.trim();
}
if (form.openaiBaseUrl !== (settings()?.openai_base_url || '')) {
@ -454,7 +455,8 @@ export const AISettings: Component = () => {
// Revert on failure
setForm('enabled', !newValue);
logger.error('[AISettings] Failed to toggle AI:', error);
notificationStore.error('Failed to update AI setting');
const message = error instanceof Error ? error.message : 'Failed to update AI setting';
notificationStore.error(message);
}
}}
disabled={loading() || saving()}