From 0271c1e78d8a269435161ab0cf0576c425ffbb08 Mon Sep 17 00:00:00 2001 From: rcourtman Date: Sun, 9 Nov 2025 00:25:42 +0000 Subject: [PATCH] Fix release checklist to upload checksums.txt FIRST (fixes #671 race condition) User ZaDarkSide reported that checksums.txt was being uploaded last, causing update failures for users who check immediately after release. The auto-updater downloads checksums.txt first, but if it's not available yet, the update fails with 'no checksum file found'. Changed upload order to: 1. checksums.txt (FIRST - critical for auto-updates) 2. tarballs, zips, helm chart 3. install.sh 4. SHA256 files This prevents the race condition where fast users get update failures. --- RELEASE_CHECKLIST.md | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/RELEASE_CHECKLIST.md b/RELEASE_CHECKLIST.md index 078e84b..c761e4a 100644 --- a/RELEASE_CHECKLIST.md +++ b/RELEASE_CHECKLIST.md @@ -150,6 +150,9 @@ git pull - Update release notes: `gh release edit v4.X.X --repo rcourtman/Pulse --notes "..."` - Delete and recreate: `gh release delete v4.X.X --repo rcourtman/Pulse --yes` - Skip if already complete +- [ ] **CRITICAL**: Upload checksums.txt FIRST to prevent update failures (related to #671) + - Users who check for updates immediately after release need checksums.txt + - If it's uploaded last, auto-updates will fail with "no checksum file found" - [ ] For RC/beta releases: ```bash gh release create v4.X.X \ @@ -157,7 +160,7 @@ git pull --prerelease \ --title "v4.X.X-rc.X" \ --notes-file release-notes.md \ - release/*.tar.gz release/*.zip release/*.tgz release/*.sh release/*.txt release/*.sha256 + release/checksums.txt release/*.tar.gz release/*.zip release/*.tgz release/*.sh release/*.sha256 ``` - [ ] For stable releases: ```bash @@ -165,7 +168,7 @@ git pull --repo rcourtman/Pulse \ --title "v4.X.X" \ --notes-file release-notes.md \ - release/*.tar.gz release/*.zip release/*.tgz release/*.sh release/*.txt release/*.sha256 + release/checksums.txt release/*.tar.gz release/*.zip release/*.tgz release/*.sh release/*.sha256 ``` - [ ] Verify release was created with all ~30 artifacts (check asset count matches previous releases) - [ ] Check download links work