danvics/Pulse
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: ensure hideLocalLogin is set when showing login after logout. Related to #857

Browse source 
When the user logged out, the code would immediately set needsAuth=true
and return WITHOUT first fetching /api/security/status. This meant the
securityStatus signal was null, causing shouldShowLocalLogin() in Login.tsx
to return true (since !undefined === true).

Now we always fetch security status before showing the login form, even
in the just_logged_out path. This ensures hideLocalLogin, oidcEnabled,
and other OIDC settings are properly available to the Login component.
This commit is contained in:
rcourtman 2025-12-20 00:04:19 +00:00
parent a340833397
commit 010d0f0e86
1 changed files with 27 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

35
frontend-modern/src/App.tsx
View file

@ -497,16 +497,9 @@ function App() {
// Check if we just logged out - if so, always show login page
const justLoggedOut = localStorage.getItem('just_logged_out');
if (justLoggedOut) {
localStorage.removeItem('just_logged_out');
logger.debug('[App] User logged out, showing login page');
setHasAuth(true); // Force showing login instead of setup
setNeedsAuth(true);
setIsLoading(false);
return;
}
// First check security status to see if auth is configured
// We need this for ALL paths to properly set hideLocalLogin, oidcEnabled, etc.
try {
const securityRes = await apiFetch('/api/security/status');
@ -520,8 +513,34 @@ function App() {
} catch (clearError) {
logger.warn('[App] Failed to clear stored auth after 401', clearError);
}
// Still try to parse security data from 401 response for OIDC settings
// If not available, Login component will fetch it on mount
setHasAuth(false);
setNeedsAuth(true);
setIsLoading(false);
return;
}
// Handle just_logged_out AFTER we have security status
if (justLoggedOut) {
localStorage.removeItem('just_logged_out');
logger.debug('[App] User logged out, showing login page');
// Parse security data to get hideLocalLogin, oidcEnabled, etc.
if (securityRes.ok) {
const securityData = await securityRes.json();
setSecurityStatus({
hasAuthentication: securityData.hasAuthentication || false,
oidcEnabled: securityData.oidcEnabled,
oidcIssuer: securityData.oidcIssuer,
oidcClientId: securityData.oidcClientId,
oidcEnvOverrides: securityData.oidcEnvOverrides,
hideLocalLogin: securityData.hideLocalLogin,
deprecatedDisableAuth: securityData.deprecatedDisableAuth,
});
}
setHasAuth(true); // Force showing login instead of setup
setNeedsAuth(true);
setIsLoading(false);
return;
}