From 8ca8ae2fdc9b1170d113df3b949e7c4b6a68ad6f Mon Sep 17 00:00:00 2001 From: zaphod-black Date: Sat, 1 Nov 2025 22:26:14 -0500 Subject: [PATCH] Fix: Detect "unknown" string as incomplete configuration MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Extended incomplete configuration check to handle configs that have literal "unknown" string values (not just empty strings). This handles cases where config migration or incomplete setup left placeholder "unknown" values in PBS_SERVER or PBS_DATASTORE fields. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude --- pbs-client-installer.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pbs-client-installer.sh b/pbs-client-installer.sh index 0c27e12..61a3452 100755 --- a/pbs-client-installer.sh +++ b/pbs-client-installer.sh @@ -168,7 +168,8 @@ show_targets_list() { echo "Target: $target" # Check if config seems incomplete - if [ -z "$PBS_SERVER" ] || [ -z "$PBS_DATASTORE" ]; then + if [ -z "$PBS_SERVER" ] || [ -z "$PBS_DATASTORE" ] || \ + [ "$PBS_SERVER" = "unknown" ] || [ "$PBS_DATASTORE" = "unknown" ]; then echo " Status: ⚠ Incomplete configuration" echo " Action: Use option 3 (Edit target) to reconfigure" else