From 3b88717091a1c965ce96ab7e7f7d4629c1c9f258 Mon Sep 17 00:00:00 2001 From: Sami Ansari <74448287+y0usaf@users.noreply.github.com> Date: Fri, 13 Feb 2026 00:41:25 +0000 Subject: [PATCH] fix(nix): address PR #778 review comments (#800) - Replace patchShebangs with targeted substituteInPlace for tsc/vite shebangs, pointing them to bun instead of node - Use `bun run build` instead of `${pkgs.bun}/bin/bun run build` since bun is already in nativeBuildInputs - Remove nodejs from nativeBuildInputs (no longer needed) - Add comment explaining why doCheck is disabled --- flake.nix | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/flake.nix b/flake.nix index 3a44bbe..e71b7ad 100644 --- a/flake.nix +++ b/flake.nix @@ -96,11 +96,14 @@ preBuild = '' cp -r ${bunDeps}/node_modules node_modules chmod -R +w node_modules - patchShebangs node_modules + substituteInPlace node_modules/.bin/{tsc,vite} \ + --replace-fail "/usr/bin/env node" "${lib.getExe pkgs.bun}" export HOME=$TMPDIR - ${pkgs.bun}/bin/bun run build + bun run build ''; + # Tests require runtime resources (audio devices, model files, GPU/Vulkan) + # not available in the Nix build sandbox doCheck = false; # The tauri hook's installPhase expects target/ in cwd, but our @@ -118,7 +121,6 @@ pkg-config wrapGAppsHook4 bun - nodejs jq cmake llvmPackages.libclang